Introduce a session property to print the before and after plan node of specified optimizations#20035
Merged
mlyublena merged 1 commit intoprestodb:masterfrom Jul 13, 2023
Conversation
fb531a7 to
6bdf240
Compare
2980bd0 to
9a95c63
Compare
feilong-liu
reviewed
Jul 10, 2023
Contributor
feilong-liu
left a comment
There was a problem hiding this comment.
My understanding is that this only targets iterative optimizer rule, is this correct?
presto-main/src/main/java/com/facebook/presto/sql/planner/iterative/IterativeOptimizer.java
Outdated
Show resolved
Hide resolved
9a95c63 to
2e22307
Compare
Contributor
Author
No, also the plan optimizers. |
2e22307 to
92a05f5
Compare
feilong-liu
approved these changes
Jul 12, 2023
pranjalssh
approved these changes
Jul 13, 2023
...in/src/main/java/com/facebook/presto/sql/planner/optimizations/OptimizerResultCollector.java
Outdated
Show resolved
Hide resolved
92a05f5 to
c9f8363
Compare
…of specified optimizations Introduce a new session property verbose_optimizer_results with possible values 'ALL' | 'NONE' | <OptimizerClassName>[,<OptimizerClassName>...] When enabled, the 'before' and 'after' for selected optimizations will be printed at the end of the explain plan. When 'ALL' is specified, it will print the result of every applicable optimizer.
c9f8363 to
30b6a24
Compare
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new session property verbose_optimizer_results with possible values
'ALL' | 'NONE' | <OptimizerClassName> [,<OptimizerClassName>...]When enabled, the 'before' and 'after' for selected optimizations will be printed at the end of the explain plan. When 'ALL' is specified, it will print the result of every applicable optimizer.
For example: